service/ecr: Refactor to use keyvaluetags library #10325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: #7926 Output from acceptance testing: ``` --- PASS: TestAccAWSEcrDataSource_ecrImage (13.77s) --- PASS: TestAccAWSEcrRepository_basic (14.42s) --- PASS: TestAccAWSEcrRepository_immutability (14.53s) --- PASS: TestAccAWSEcrDataSource_ecrRepository (16.21s) --- PASS: TestAccAWSEcrRepository_tags (20.90s) ```
bflad
added
the
technical-debt
ghost
added
size/L
bflad
added a commit
that referenced
this pull request
Oct 1, 2019
Reference: #10325 (comment) Since the file naming and implementation of these files was inconsistent, the labeling was sometimes inconsistent. We won't be accepting changes to these files anymore in preference of replacing them with the auto-generated `keyvaluetags` library, so removing the hashibot labeling of them.
bflad
removed
the
service/elasticache
ryndaniels
approved these changes
Oct 22, 2019
There was a problem hiding this comment.
One minor question/nit, otherwise lgtm!
--- PASS: TestAccAWSEcrLifecyclePolicy_basic (9.66s)
--- PASS: TestAccAWSEcrRepository_basic (9.80s)
--- PASS: TestAccAWSEcrRepository_immutability (9.85s)
--- PASS: TestAccAWSEcrRepositoryPolicy_basic (10.47s)
--- PASS: TestAccAWSEcrLifecyclePolicy_import (10.83s)
--- PASS: TestAccAWSEcrDataSource_ecrRepository (10.95s)
--- PASS: TestAccAWSEcrDataSource_ecrImage (11.02s)
--- PASS: TestAccAWSEcrRepository_tags (13.78s)
--- PASS: TestAccAWSEcrRepositoryPolicy_iam (27.06s)
|
|
||
| d.SetId(aws.StringValue(repository.RepositoryName)) | ||
| d.Set("arn", repository.RepositoryArn) | ||
| d.Set("arn", arn) | ||
| d.Set("registry_id", repository.RegistryId) |
There was a problem hiding this comment.
Do any of these need aws.StringValues as well?
There was a problem hiding this comment.
Good question and no -- ResourceData.Set() automatically handles pointers: https://github.com/hashicorp/terraform-plugin-sdk/blob/6f51fdc99e1e3a27b7445f873f217e2d961869a3/helper/schema/resource_data.go#L178
|
Resolved plugin SDK conflicts and re-verified: |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Reference: #7926
Release note for CHANGELOG:
Output from acceptance testing: